fix: decoding unsigned AlgoSigner txn as signed #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi there, thanks a lot for open-sourcing this work, it's been incredibly useful to me and I'm sure many others. I came across this inconsistency and I believe based on the other clients, the connectedAccounts condition should be negated? Otherwise feel free to ignore if I misunderstood something.
gabrielkuettel
approved these changes
Dec 2, 2022
|
You are correct! Thank you for spotting this bug. I'll include this in the upcoming V1 release next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, thanks a lot for open-sourcing this work, it's been incredibly useful to me and I'm sure many others. I came across this inconsistency and I believe based on the other clients, the connectedAccounts condition should be negated? Otherwise feel free to ignore if I misunderstood something.