Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reactive algodClient for SolidJS #204

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Conversation

SilentRhetoric
Copy link
Contributor

Added algodClient to the store in the core package and modified the SolidJS package to set this property on the store when network is changed. Now useWallet provides a reactive algodClient via the store rather than a signal, which was not behaving reactively before.

@SilentRhetoric SilentRhetoric marked this pull request as ready for review July 28, 2024 17:05
Copy link
Collaborator

@drichar drichar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I'll update the other adapters to similarly handle the algodClient from the store. Thanks for the contribution and for your efforts to get it working correctly!

@drichar drichar changed the title Reactive algodClient for SolidJS feat: reactive algodClient for SolidJS Aug 2, 2024
@drichar drichar merged commit 11ef688 into TxnLab:main Aug 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants