Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapted bootstrap to be backwards compatible between old and new names #18

Merged

Conversation

andrei-tyk
Copy link
Contributor

@andrei-tyk andrei-tyk commented Oct 17, 2023

Description

We have renamed our "Tyk Enterprise Portal" chart to "Tyk Developer Portal". This PR aims to add the required changes to the environment variables to allow for the new changes and for backward compatibility.

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

Copy link
Member

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @andrei-tyk. I've added my comments and would appreciate your thoughts on them. Additionally, could you kindly update the PR description and details?

constants/constants.go Outdated Show resolved Hide resolved
helpers/operator.go Outdated Show resolved Hide resolved
@buraksekili buraksekili merged commit 3404ae0 into main Oct 26, 2023
1 check passed
@buraksekili buraksekili deleted the TT-10195-rename-tyk-enterprise-portal-to-tyk-dev-portal branch October 26, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants