Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally don't strip trailing slash when proxying only root target url #1972

Merged
merged 1 commit into from
Nov 10, 2018

Conversation

joshblakeley
Copy link
Member

@joshblakeley joshblakeley commented Nov 8, 2018

Fixes #1538

Uses new api definition config option proxy.disable_strip_prefix

It only takes effect in one case: when there is no path to append onto the target url and when the config option is true

reverse_proxy.go Outdated Show resolved Hide resolved
apidef/api_definitions.go Outdated Show resolved Hide resolved
@buger buger merged commit 9a9696e into master Nov 10, 2018
@buger buger deleted the targeturlstripslash branch November 10, 2018 16:11
buger pushed a commit that referenced this pull request Nov 10, 2018
Fixes #1538 

Uses new api definition config option `proxy.disable_strip_prefix` 

It only takes effect in one case: when there is no path to append onto the target url and when the config option is `true`
buger pushed a commit that referenced this pull request Nov 10, 2018
Fixes #1538 

Uses new api definition config option `proxy.disable_strip_prefix` 

It only takes effect in one case: when there is no path to append onto the target url and when the config option is `true`
buger pushed a commit that referenced this pull request Jan 15, 2019
Fixes #1538 

Uses new api definition config option `proxy.disable_strip_prefix` 

It only takes effect in one case: when there is no path to append onto the target url and when the config option is `true`

(cherry picked from commit 9a9696e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Root listen path 302 redirect
2 participants