Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key creation endpoint fixed #1995

Merged
merged 1 commit into from
Nov 27, 2018
Merged

key creation endpoint fixed #1995

merged 1 commit into from
Nov 27, 2018

Conversation

dencoded
Copy link
Contributor

added changes for #1986 (comment)

the problem was that our UI passes API-level limit with zero value:
screen shot 2018-11-26 at 3 21 35 pm

So backend was picking up that zero value and used it for rate/quota limits. A non-nil API level limit acts as a trigger to apply limits on API level - added special check to reset api limit to nil if it is not nil but has zero-value struct in it.

@dencoded dencoded requested a review from buger November 26, 2018 22:02
@buger buger merged commit 79fd301 into master Nov 27, 2018
@buger buger deleted the quota-counter-fix branch November 27, 2018 08:30
buger pushed a commit that referenced this pull request Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants