Move API schema to Tyk repo #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having it in analytics repo cause lot of issues, since we constantly forgot to update it, when adding new fields. In addition to adding schema, this PR also ensure automatic tests, which run schema validation against current API definition. Also, added `DummyAPI` method, which returns pre-populated API definition record, with initialized nested fields. This method used for both schema tests, and for the Dashboard to generate example JSON object of an API.
buger
added a commit
that referenced
this pull request
Jan 18, 2019
Having it in analytics repo cause a lot of issues, since we constantly forgot to update it, when adding new fields. In addition to adding a schema, this PR also ensure automatic tests, which run schema validation against current API definition. Also, added `DummyAPI` method, which returns pre-populated API definition record, with initialized nested fields. This method used for both schema tests, and for the Dashboard to generate example JSON object of an API. Manually merged based on f9e008e
buger
added a commit
that referenced
this pull request
Jan 18, 2019
Having it in analytics repo cause a lot of issues, since we constantly forgot to update it, when adding new fields. In addition to adding a schema, this PR also ensure automatic tests, which run schema validation against current API definition. Also, added `DummyAPI` method, which returns pre-populated API definition record, with initialized nested fields. This method used for both schema tests, and for the Dashboard to generate example JSON object of an API. Manually merged based on f9e008e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having it in analytics repo cause a lot of issues, since we constantly forgot to update it, when adding new fields.
In addition to adding a schema, this PR also ensure automatic tests, which run schema validation against current API definition.
Also, added
DummyAPImethod, which returns pre-populated API definition record, with initialized nested fields. This method used for both schema tests, and for the Dashboard to generate example JSON object of an API.