Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-496 Removing disable_management_poller config opt #3357

Merged
merged 3 commits into from
Oct 9, 2020

Conversation

tbuchaillot
Copy link
Contributor

Description

Removing uptime_tests.disable_management_poller config option.
Now, uptime_tests.disable is the trigger of the HostCheckerManager. If it is true, the gateway won't be able to become the Host checker manager.

Related Issue

https://tyktech.atlassian.net/browse/TT-496

Motivation and Context

https://tyktech.atlassian.net/browse/TT-496

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
    • If new config option added, ensure that it can be set via ENV variable
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

Copy link
Contributor

@gernest gernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. I left a suggestion.

gateway/server.go Outdated Show resolved Hide resolved
@tbuchaillot tbuchaillot self-assigned this Oct 9, 2020
@tbuchaillot tbuchaillot changed the title Removing disable_management_poller config opt [TT-496] Removing disable_management_poller config opt Oct 9, 2020
Copy link
Contributor

@gernest gernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbuchaillot tbuchaillot changed the title [TT-496] Removing disable_management_poller config opt TT-496 Removing disable_management_poller config opt Oct 9, 2020
@gernest
Copy link
Contributor

gernest commented Oct 9, 2020

@tbuchaillot I missed that this is against release-2.9 branch. I think It should be against master branch but backported to release-2.9

@tbuchaillot
Copy link
Contributor Author

@tbuchaillot I missed that this is against release-2.9 branch. I think It should be against master branch but backported to release-2.9

@gernest that config option was only in 2.9 - we didn't go against master since we tried to backporting it from master to release-2.9 with @matiasinsaurralde and had a lot of problems. I'm going to send another PR for master with all the HostCheckerManager changes.

@buger
Copy link
Member

buger commented Oct 9, 2020

Ok, and ensure that this new PR will have all the tests.

@buger buger merged commit 3129c2f into release-2.9 Oct 9, 2020
@buger buger deleted the removing-manager-poller-conf branch October 9, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants