-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the user to run the Control API on a different port #423
Allow the user to run the Control API on a different port #423
Conversation
Cool! Can you update PR description with steps on how to configure and test separate port? |
Do not forget that after merging we should update documentation. |
@matiasinsaurralde also please rebase onto master instead of merging master onto PR branches |
Has this been tested with hot reload logic? |
Good point, linking #431 |
@lonelycode I was able to reproduce the issue (APIs not being loaded after reload), and after rewriting this part of |
a693d81
to
d5fae3f
Compare
@mvdan Updated! |
Lurvely |
Test instructions By default the control API will be exposed in the same IP/port the gateway is using. For example, to list the APIs:
To configure a separate control API port you may set the
It shouldn't be available in the gateway port anymore! |
@buger This is feature request? If is please add label and milestone |
@ilijabojanovic this is PR, label and milestone added to underlying issue mentioned in description. |
@buger thanks for clarification |
@ilijabojanovic ready for testing as well @matiasinsaurralde can you resolve conflicts in meantime. |
@matiasinsaurralde some of this conflicts potentially dangerous (in main.go), so pls fix conflicts before it goes to QA. |
@matiasinsaurralde bump |
d5fae3f
to
88aac03
Compare
@leon Updated! |
@ConsM pls update documentation about |
@buger verified and approved for merge |
Related to #354.