Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to run the Control API on a different port #423

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

matiasinsaurralde
Copy link
Contributor

Related to #354.

@buger
Copy link
Member

buger commented Jan 31, 2017

Cool! Can you update PR description with steps on how to configure and test separate port?

@buger
Copy link
Member

buger commented Jan 31, 2017

Do not forget that after merging we should update documentation.

@mvdan
Copy link
Contributor

mvdan commented Jan 31, 2017

@matiasinsaurralde also please rebase onto master instead of merging master onto PR branches

@lonelycode
Copy link
Member

Has this been tested with hot reload logic?

@buger
Copy link
Member

buger commented Jan 31, 2017

Good point, linking #431

@matiasinsaurralde
Copy link
Contributor Author

@lonelycode I was able to reproduce the issue (APIs not being loaded after reload), and after rewriting this part of listen it works fine.
@buger Will add the instructions now.

@matiasinsaurralde matiasinsaurralde force-pushed the control-api-port branch 5 times, most recently from a693d81 to d5fae3f Compare January 31, 2017 16:38
@matiasinsaurralde
Copy link
Contributor Author

@mvdan Updated!

@lonelycode
Copy link
Member

Lurvely

@matiasinsaurralde
Copy link
Contributor Author

Test instructions

By default the control API will be exposed in the same IP/port the gateway is using. For example, to list the APIs:

curl -H 'x-tyk-authorization: 352d20ee67be67f6340b4c0605b044b7' http://localhost:8080/tyk/apis/

To configure a separate control API port you may set the control_api_port field in tyk.conf. If you set it to 7777, you may try this command:

curl -H 'x-tyk-authorization: 352d20ee67be67f6340b4c0605b044b7' http://localhost:7777/tyk/apis/

It shouldn't be available in the gateway port anymore!

@ilijabojanovic
Copy link
Member

@buger This is feature request? If is please add label and milestone

@buger
Copy link
Member

buger commented Feb 1, 2017

@ilijabojanovic this is PR, label and milestone added to underlying issue mentioned in description.

@ilijabojanovic
Copy link
Member

@buger thanks for clarification

@buger
Copy link
Member

buger commented Feb 7, 2017

@ilijabojanovic ready for testing as well

@matiasinsaurralde can you resolve conflicts in meantime.

@buger
Copy link
Member

buger commented Feb 9, 2017

@matiasinsaurralde some of this conflicts potentially dangerous (in main.go), so pls fix conflicts before it goes to QA.

@buger
Copy link
Member

buger commented Feb 15, 2017

@matiasinsaurralde bump

@matiasinsaurralde
Copy link
Contributor Author

@leon Updated!

@buger
Copy link
Member

buger commented Feb 16, 2017

@ConsM pls update documentation about control_api_port flag.

@buger buger merged commit 26043b4 into TykTechnologies:master Feb 16, 2017
@ilijabojanovic
Copy link
Member

@buger verified and approved for merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants