-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-10532] Update taskfile, CI tests #6350
[TT-10532] Update taskfile, CI tests #6350
Conversation
API Changes no api changes detected |
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
8358704
to
9b304fe
Compare
3243323
to
777f008
Compare
Quality Gate passedIssues Measures |
2 similar comments
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
bbdd7f6
to
8d3fbf3
Compare
Quality Gate passedIssues Measures |
### **User description** The change introduced in #6350 changed the exit-code incorrectly. Added comment. ___ ### **PR Type** bug fix, enhancement ___ ### **Description** - Fixed the `golangci-lint` step in the CI workflow to use `issues-exit-code=0` to ensure proper data passing to SonarCloud. - Added comments to clarify the necessity of this change. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix </strong></td><td><table> <tr> <td> <details> <summary><strong>ci-tests.yml</strong><dd><code>Fix golangci-lint exit code and add explanatory comments</code> </dd></summary> <hr> .github/workflows/ci-tests.yml <li>Added comments to explain the need for <code>issues-exit-code=0</code> in <br>golangci-lint step.<br> <li> Changed <code>issues-exit-code</code> from 1 to 0 in golangci-lint step.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6369/files#diff-03609cb60b0c6e92fb771eb8787d6722b8c31ca4c03eabc788e147acd8c6fb43">+3/-1</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions Co-authored-by: Tit Petric <tit@tyk.io>
This PR implements:
Taskfile.yml, .taskfiles/test.yml, taskfiles/deps/Taskfile.yml:
test:e2e
andtest:e2e-combined
. By default they run without-race
.ci-tests.yml:
task test:e2e-combined args="-race -timeout=15m"
task test:coverage
to print per-package coverage reporttask test:report
at to print slowest tests (only available ine2e-combined
)make lint
(restore cache first)Pipeline for sonarcloud is now pinned to redis7, there is some unnecessary duplication due to the redis matrix and some actions like golangci-lint unfortunately run twice. Our next step should be to make the redis 7 pipeline required, and then remove the redis 5 pipeline, and then sanitize the state in a future review.
storage: test fix for a data race
gateway: rpc_test.go, agreed marking RPC test as flaky due to sensitivity to
-race
(ok'd with @sredxny)docker/services: support REDIS_IMAGE to override for matrix test
https://tyktech.atlassian.net/browse/TT-10532