fix: Formatting Toolbar not hiding when clicking on elements outside it #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
reviewed
Jun 14, 2023
packages/core/src/extensions/FormattingToolbar/FormattingToolbarPlugin.ts
Show resolved
Hide resolved
YousefED
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatting toolbar is supposed to hide if the editor blurs, unless the element the focus is moving to is the formatting toolbar itself. The condition which checked for this was incorrect, and instead checked if the focus moved to any descendant of the formatting toolbar's parent element. Since the formatting toolbar gets appended to the
doc, it meant that the toolbar would not be closed if clicking on any element inside thedoc.Closes #161
TODO:
document.bodyto select inputs with the mouse. Because of that, toolbar disappears since popup is not a descendant. There is an easy fix but it's extremely ugly.