Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

Enable to update/restart the language client #18

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Enable to update/restart the language client #18

merged 2 commits into from
Mar 23, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Mar 15, 2023

Right now, changing the language client configuration requires to dispose the monaco editor that contains the language client. This change allows to just restart the language client with the new configuration.

Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, rename the method. Otherwise, thank you 🎉

@@ -156,6 +156,14 @@ export class MonacoEditorLanguageClientWrapper {
}
}

async restart(): Promise<string> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about restartLanguageClient?

Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msujew msujew merged commit 4457dbd into main Mar 23, 2023
@msujew msujew deleted the msujew/restart branch March 23, 2023 09:58
kaisalmen added a commit that referenced this pull request Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants