Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

New example and config changes #37

Closed
wants to merge 2 commits into from
Closed

Conversation

Stuey61296
Copy link
Contributor

  • Added another example for the react wrapper with a pyright language server
  • Updated interfaces, types and configurations

@kaisalmen
Copy link
Collaborator

@Stuey61296 what about making the monaco-languageclient-examples package publicly available on npm. Then we could just take the server from there. This would also be helpful with the json languageserver. We have just keep the start scripts here and use the dependencies from node_modules. I will test this.

@Stuey61296
Copy link
Contributor Author

@Stuey61296 what about making the monaco-languageclient-examples package publicly available on npm. Then we could just take the server from there. This would also be helpful with the json languageserver. We have just keep the start scripts here and use the dependencies from node_modules. I will test this.

I think this a good idea, will definitely make it easier to maintain going forward. Do you need me to look into this or will you do it as part of the next release you do?

@kaisalmen
Copy link
Collaborator

Do you need me to look into this or will you do it as part of the next release you do?

I will test this (release new packages) with the json example and if that works you could rebase this PR and do the same with the python server.

@kaisalmen
Copy link
Collaborator

@Stuey61296 Done. The server integrations for python and json LSs are already available on main. Please rebase the PR.

@kaisalmen
Copy link
Collaborator

I performed the rebase here already: https://github.com/TypeFox/monaco-components/tree/react-python

You can reset your branch to there if you like. The changes look good already and it works as expected.

Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes you made are fine and the corrections are great. Thank you.

In the rebase I did all your example and monaco-editor-wrapper changes are kept. Only the python server is now launched from the new monaco-languageclient-examples.

@kaisalmen
Copy link
Collaborator

kaisalmen commented Aug 31, 2023

I now merged the rebased version as there were no further changes required from your side. Your name is on the changes! 🎉 I only removed what I wrote above. I will release the new major versions later today.

@kaisalmen kaisalmen closed this Aug 31, 2023
@kaisalmen
Copy link
Collaborator

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants