Skip to content

Commit f292028

Browse files
deftomatjohnnyreilly
authored andcommitted
fix: handle unhandled "write EPIPE" error (#306)
* fix: handle unhandled "write EPIPE" error Killing webpack during the running typechecks on Node 12 could cause an unhandled error * fix: do not omit "non-null assertion" operator * style: resolve tslint warning * fix: upgrade Node typing to v11 * test: add Node v12 to test environments
1 parent cb31cae commit f292028

File tree

5 files changed

+12
-7
lines changed

5 files changed

+12
-7
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ os:
55

66
language: node_js
77
node_js:
8+
- 12
89
- 10
910
- 8
1011

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@
114114
"@types/micromatch": "^3.1.0",
115115
"@types/minimatch": "^3.0.1",
116116
"@types/mock-require": "^2.0.0",
117-
"@types/node": "^8.10.38",
117+
"@types/node": "^11.0.0",
118118
"@types/rimraf": "^2.0.2",
119119
"@types/semver": "^5.5.0",
120120
"@types/webpack": "^4.4.19",

src/cluster.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ for (let num = 0; num < division; num++) {
1515
workers.push(
1616
childProcess.fork(path.resolve(__dirname, './service.js'), [], {
1717
execArgv: ['--max-old-space-size=' + process.env.MEMORY_LIMIT],
18-
env: { ...process.env, WORK_NUMBER: num },
18+
env: { ...process.env, WORK_NUMBER: num.toString() },
1919
stdio: ['inherit', 'inherit', 'inherit', 'ipc']
2020
})
2121
);

src/service.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@ import { createEslinter } from './createEslinter';
2323

2424
const rpc = new RpcProvider(message => {
2525
try {
26-
process.send!(message);
26+
process.send!(message, undefined, undefined, error => {
27+
if (error) {
28+
process.exit();
29+
}
30+
});
2731
} catch (e) {
2832
// channel closed...
2933
process.exit();

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1208,10 +1208,10 @@
12081208
version "10.12.18"
12091209
resolved "https://registry.yarnpkg.com/@types/node/-/node-10.12.18.tgz#1d3ca764718915584fcd9f6344621b7672665c67"
12101210

1211-
"@types/node@^8.10.38":
1212-
version "8.10.47"
1213-
resolved "https://registry.yarnpkg.com/@types/node/-/node-8.10.47.tgz#e19b2f50f68697013db9e8abb5ad3ddc30faaa0b"
1214-
integrity sha512-HshJQ2myCc05qYuR99HvJRK5rWOPwKLumVDrpizY58OJUVEgRwd7RtxqDOOi350VGxFI8hrCtjR7IaDfo0S12Q==
1211+
"@types/node@^11.0.0":
1212+
version "11.13.17"
1213+
resolved "https://registry.yarnpkg.com/@types/node/-/node-11.13.17.tgz#2e7efbfe5253561087812571e5e6a1e4b1d6295b"
1214+
integrity sha512-7W3kSMa8diVH6s24a8Qrmvwu+vG3ahOC/flMHFdWSdnPYoQI0yPO84h5zOWYXAha2Npn3Pw3SSuQSwBUfaniyQ==
12151215

12161216
"@types/retry@^0.12.0":
12171217
version "0.12.0"

0 commit comments

Comments
 (0)