New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #336. Add happypack compatibility mode #547

Merged
merged 6 commits into from May 21, 2017

Conversation

Projects
None yet
2 participants
@aindlq
Copy link
Contributor

aindlq commented May 21, 2017

No description provided.

@aindlq aindlq force-pushed the aindlq:happypack-mode branch from ace7f26 to b40c036 May 21, 2017

@johnnyreilly

This comment has been minimized.

Copy link
Member

johnnyreilly commented May 21, 2017

This is brilliant! Thanks​! Do you know why the test is failing?

@aindlq

This comment has been minimized.

Copy link
Contributor

aindlq commented May 21, 2017

forgot to add happypack as a dependency, should be ok with the next run

johnnyreilly added some commits May 21, 2017

Update README.md
Typos
Made happypack a devDependency
In the longer term move this into test itself. Need to rejig test framework a little first.
@johnnyreilly

This comment has been minimized.

Copy link
Member

johnnyreilly commented May 21, 2017

Cool - thanks! Just doing some tweaks

@johnnyreilly

This comment has been minimized.

Copy link
Member

johnnyreilly commented May 21, 2017

This looks good - let's merge!

@johnnyreilly johnnyreilly merged commit 70f0595 into TypeStrong:master May 21, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment