fix: Minimatch pattern assertion on Windows OS #1304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure if that does the job (doesn't come up with some repercussions), but I don't have experience with minimatch package.
You can experience an error on Windows, when you've your project on other drive than system drive. With the things how
absolutePath
expression works, you won't land magically on system drive like the comparison pattern expects you to, so I removed theC:
from the beginning of the pattern.