feat: Make mappings and getMapping public
#2407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed I can override buildUrls, nevermind. 😁 Still useful though. Will leave it open if you want to merge. |
|
I'm not sure I want to merge this -- I've never liked how the URL building was implemented, and making this part of the public API seems like a step in the wrong direction... I've been experimenting with alternative generation schemes on the beta branch, but am not fully happy with it yet |
|
Should I close the PR? |
|
Feel free to leave it open for now, if I vent get the rework into a state I'm happy with, I'll reconsider merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for the overriding of
mappings, so that they can be overriden by child themes that extendDefaultTheme.This will resolve current issues such as #2111 with the creation of a simple theme like in https://github.com/NikolaRHristov/TypeScriptESBuild/blob/main/Source/Class/Theme.ts