Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to manually change a number of users portal or quota through manual override #52

Closed
5 tasks done
astrochun opened this issue Aug 13, 2020 · 1 comment · Fixed by #61
Closed
5 tasks done
Assignees
Labels
enhancement New feature or request scripts Script development
Milestone

Comments

@astrochun
Copy link
Contributor

astrochun commented Aug 13, 2020

This issue has split off from #43.

Primary work will be in user_update script. At the moment, this script can only handle a single patron.
Minimum: a comma-separated list of netid
Desired: Minimum + ability to use simple txt file with netid's (one per row).

  • Update user_update:
    - [x] Split out netid by commas. Best to have as a set to avoid any duplicate entries
    - [x] Handling of incorrect ID (via user_uaid)
  • Update `ldap_query.uid_query() to provide appropriate search criteria. This will be tough because of handling the users that have access and the users that do not have access (though set operations should avoid conflicts). Larger issue is handling incorrect netid's.
  • Calls to get_current_groups needs to handle multi-user. Best to use dict within dict
  • For full compatibility, the quota case needs a root option which implies no association with a quota
  • Improvements needed in ManualOverride to handle multi-user add to tables, etc.
@astrochun astrochun added enhancement New feature or request scripts Script development labels Aug 13, 2020
@astrochun astrochun added this to To do in ReDATA Patron Management Software via automation Aug 13, 2020
@astrochun astrochun self-assigned this Aug 13, 2020
@astrochun astrochun added this to the v0.12.0 milestone Aug 13, 2020
@astrochun
Copy link
Contributor Author

This has been escalated higher. It might be best to have this as a feature as I don't think it's an easy fix. Will push to develop to use temporarily until v0.12.0 is complete.

@astrochun astrochun moved this from To do to In progress in ReDATA Patron Management Software Sep 2, 2020
astrochun added a commit that referenced this issue Sep 9, 2020
Add verbose option in get_current_groups
astrochun added a commit that referenced this issue Sep 10, 2020
Fix calls to mo.update_dataframe when root case
astrochun added a commit that referenced this issue Sep 10, 2020
log revert_command if membership is empty

append quota to revert_command (including root)
@astrochun astrochun moved this from In progress to Needs Review / Testing in ReDATA Patron Management Software Sep 18, 2020
@astrochun astrochun moved this from Needs Review / Testing to Ready to merge with release in ReDATA Patron Management Software Sep 18, 2020
astrochun added a commit that referenced this issue Sep 23, 2020
Include description about quota root setting
astrochun added a commit that referenced this issue Sep 23, 2020
@astrochun astrochun mentioned this issue Sep 28, 2020
23 tasks
ReDATA Patron Management Software automation moved this from Ready to merge with release to Done Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scripts Script development
Development

Successfully merging a pull request may close this issue.

1 participant