Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grouper_base_path needs to be more generic #60

Closed
astrochun opened this issue Sep 18, 2020 · 0 comments · Fixed by #61
Closed

grouper_base_path needs to be more generic #60

astrochun opened this issue Sep 18, 2020 · 0 comments · Fixed by #61
Assignees
@astrochun
Labels
api Use of a third-party API enhancement New feature or request reorganization packaging and re-organization
Projects
ReDATA Patron Management Software
Milestone
v0.12.0

Comments

@astrochun
Copy link
Contributor

astrochun commented Sep 18, 2020 •
edited
Loading

Not necessarily a bug, but the path for the grouper_base_path is specific for the tool to add members: grouper-ws/servicesRest/json/v2_2_001/groups

As such, it will not work with some components of the Grouper API, specifically permission. There's a simple hack to strip the trailing group, but a more ideal situation is to keep it generic and set the proper endpoint as needed.

This should be implemented in release/v0.12.0

Notes:

  • It is implemented in feature/grouper_api_admin for GrouperAPI and GrouperQuery
  • Since feature/multi_user uses GrouperQuery, it should be fine when we everything is merged into release/v0.12.0
@astrochun astrochun added api Use of a third-party API enhancement New feature or request reorganization packaging and re-organization labels Sep 18, 2020
@astrochun astrochun self-assigned this Sep 18, 2020
@astrochun astrochun added this to To do in ReDATA Patron Management Software via automation Sep 18, 2020
@astrochun astrochun added this to the v0.12.0 milestone Sep 18, 2020
astrochun added a commit that referenced this issue Sep 21, 2020
@astrochun
Change grouper base path for generality #60
639d496 
Update grouper_admin and grouper_query modules accordingly
@astrochun astrochun moved this from To do to In progress in ReDATA Patron Management Software Sep 21, 2020
@astrochun astrochun moved this from In progress to Ready to merge with release in ReDATA Patron Management Software Sep 28, 2020
@astrochun astrochun mentioned this issue Sep 28, 2020
Merged
23 tasks
astrochun added a commit that referenced this issue Sep 29, 2020
@astrochun
Update README.md change log for v0.12.0 #42, #52, #57 #58, #60
0d86eb9
ReDATA Patron Management Software automation moved this from Ready to merge with release to Done Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astrochun astrochun

Labels
api Use of a third-party API enhancement New feature or request reorganization packaging and re-organization
Projects
ReDATA Patron Management Software
  
Done
Milestone
v0.12.0
Development

Successfully merging a pull request may close this issue.

release/v0.12.0 UAL-RE/ReQUIAM
1 participant
@astrochun