Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libcanard v1.0 #152

Merged
merged 24 commits into from Oct 12, 2020
Merged

Libcanard v1.0 #152

merged 24 commits into from Oct 12, 2020

Conversation

pavel-kirienko
Copy link
Member

@pavel-kirienko pavel-kirienko commented Sep 14, 2020

This PR will not be merged and may incur changes until OpenCyphal/specification#97 is approved.

I debated whether it's worth renaming "subscription" into "listener" to avoid confusion:

In Libcanard, there is a bit of an implementation-specific terminology mishap: it uses “subscribe” in the sense of “tell the library that the application wants to receive this kind of transfers”; the mishap is because I couldn’t find a better word to use. Maybe I should have used “listen” instead, like canardRxListen? I wonder if we should change it.

In the end, I decided to not change it, keeping the old verbiage. If there is interest, it's not too late to do it now.

FYI @TSC21 @PetervdPerk-NXP @dagar

EDIT: it's worth noting that despite the subject-ID range review, this changeset does not render Libcanard v1.0 wire-incompatible with v0.100, excepting fringe cases of low importance. This is because the compatibility implications have been taken into account by OpenCyphal/specification#96.

@TSC21
Copy link

TSC21 commented Sep 30, 2020

@dagar @PetervdPerk-NXP FYI

@pavel-kirienko pavel-kirienko marked this pull request as draft October 4, 2020 13:45
@pavel-kirienko pavel-kirienko marked this pull request as ready for review October 6, 2020 10:57
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@pavel-kirienko pavel-kirienko merged commit 54a004b into master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants