Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 1 Feedback #40

Closed
ahofmann4 opened this issue Jan 22, 2021 · 4 comments
Closed

Milestone 1 Feedback #40

ahofmann4 opened this issue Jan 22, 2021 · 4 comments

Comments

@ahofmann4
Copy link

Hi Group 22,

  • I enjoyed reading your proposal. It was well written and included necessary details in appropriate detail.

  • I like how there is an order to how the user would use the dashboard and a reason behind how you set it up. The dashboard concept is clear and well designed.

  • Tab 1: I am worried the text in the bar graph might be too small to read if you show all the data. Subsetting or a scroll bar might help the used look at the data easier. Where will you put the legend for the choropleth map?

  • Tab 2: will there be a max number of CMAs Sarah can select to compare?

  • Will the abbreviation CMA be explained anywhere in the dashboard?

@sbabicki
Copy link
Collaborator

Thanks @ahofmann4!

For Tab 2, would you suggest we set a maximum? I would be okay with allowing Sarah to select as many as she wants, but I'm also okay to limit the number.

@sbabicki sbabicki mentioned this issue Jan 23, 2021
4 tasks
@ahofmann4
Copy link
Author

ahofmann4 commented Jan 23, 2021 via email

@calsvein
Copy link
Collaborator

Addressing your feedback:

Tab 1: I am worried the text in the bar graph might be too small to read if you show all the data. Subsetting or a scroll bar might help the used look at the data easier. Where will you put the legend for the choropleth map?

Implemented - Our bar graph has a scroll bar.
Not implemented yet - The choropleth map won't require a legend (it should be apparent based on what dropdowns the user has selected), but we will have tooltips to display some information.

Tab 2: will there be a max number of CMAs Sarah can select to compare?

N/A - there will not be a max number of CMAs to select from. A graph will only start with one CMA, and the user will have the flexibility to remove selections if the graph becomes too noisy.

Will the abbreviation CMA be explained anywhere in the dashboard?

**This will be addressed in a future release

@sbabicki
Copy link
Collaborator

sbabicki commented Feb 7, 2021

Thanks again for your feedback @ahofmann4.
As of Milestone 4 we have implemented the remaining issues in this thread that had not been addressed yet in prior releases: increasing the height of the CMA plot so that it shows all the data and adding a legend in the bottom left corner of the choropleth.

@sbabicki sbabicki closed this as completed Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants