Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves the rendering issue with altair in example.ipynb #59

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

johnwslee
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #59 (9b3ec5b) into main (1abbd17) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   91.09%   90.90%   -0.19%     
==========================================
  Files           5        5              
  Lines         146      143       -3     
==========================================
- Hits          133      130       -3     
  Misses         13       13              
Impacted Files Coverage Δ
src/bccovideda/plot_hist_by_cond.py 82.92% <ø> (-0.80%) ⬇️
src/bccovideda/plot_line_by_date.py 90.00% <ø> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1abbd17...9b3ec5b. Read the comment docs.

@liannah
Copy link
Collaborator

liannah commented Jan 28, 2022

The coverage got down for codecov @johnwslee. Is this expected ?

@liannah liannah self-requested a review January 28, 2022 21:23
@liannah liannah added this to the Milestone 3 milestone Jan 28, 2022
@johnwslee
Copy link
Collaborator Author

I removed alt.render. thingy from our functions. That may be why we got this msg. The decrease is not that big, i believe. like 0. something

@liannah
Copy link
Collaborator

liannah commented Jan 28, 2022

I removed alt.render. thingy from our functions. That may be why we got this msg. The decrease is not that big, i believe. like 0. something

Yeah, I will merge this, and will take a look if we can make the coverage more.

@liannah liannah merged commit 2753d0f into main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants