Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plot weather data func #48

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

chenzhao2020
Copy link
Collaborator

Addressed various fixes from Marco and Chad's reviews:

  • Marco:

    • Simplified the repeated codes in plot_weather_data() function
    • Set default parameters for time_basis and col_name argument of plot_weather_data() function
    • Fix single quote mark problem in plot_weather_data() function's docstring
    • Add explaination of how to get the obs_df in plot_weather_data() function's docstring
  • Chad:

    • Delete tests/test_noaastn.py file
    • Written plot_weather_data() function in a more DRY fashion based on the suggestion, thank you for that!
    • Labled x-axis nicely when using the plot_weather_data() function with "daily"argument

@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #48 (5b6e33a) into main (df91c5e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #48   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          176       165   -11     
=========================================
- Hits           176       165   -11     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
noaastn/__init__.py 100.00% <100.00%> (ø)
noaastn/noaastn.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db5d4b...5b6e33a. Read the comment docs.

@chenzhao2020 chenzhao2020 linked an issue May 2, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package Review Suggestion For plot_weather_data
1 participant