Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emailer #13

Merged
merged 4 commits into from
Mar 13, 2021
Merged

Emailer #13

merged 4 commits into from
Mar 13, 2021

Conversation

elabandari
Copy link
Collaborator

Hey folks,

I finally have the function and tests for the emailer up and running. I did have a hard time installing the rJava library so I posted the steps in the emailer function issue.

Thanks in advance for your review.

Cheers,
Ela

@elabandari elabandari added this to the Milestone3 milestone Mar 12, 2021
athy9193
athy9193 approved these changes Mar 13, 2021
View reviewed changes
Copy link
Collaborator

@athy9193 athy9193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great! Thank you @elabandari

@athy9193 athy9193 merged commit 397b2a4 into main Mar 13, 2021
@elabandari elabandari mentioned this pull request Mar 13, 2021
Closed
@athy9193
Copy link
Collaborator

Added notes from @elabandari on installation:

A note about this function: rJava is a dependency that may be tricky to get running.

To get rJava you need to install java (jdk8) from https://www.oracle.com/java/technologies/javase/javase-jdk8-downloads.html

And then run the following command sudo R CMD javareconf

@athy9193 athy9193 linked an issue Mar 13, 2021 that may be closed by this pull request
Function 4 : Emailer #8
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athy9193 athy9193 athy9193 approved these changes

@JuntingHe JuntingHe Awaiting requested review from JuntingHe

@elina-linglin elina-linglin Awaiting requested review from elina-linglin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Milestone3
Development

Successfully merging this pull request may close these issues.

Function 4 : Emailer
2 participants
@elabandari @athy9193