Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed DBC Error on Main #84

Merged
merged 3 commits into from
May 15, 2024
Merged

Fixed DBC Error on Main #84

merged 3 commits into from
May 15, 2024

Conversation

AarjavJain101
Copy link
Contributor

Error Received:
cantools.database.errors.Error: The signal <SOME_SIGNAL> length 0 is not greater than 0 in message MCBDiagnostics.

Problem:

  • This signal had a length of 0 bits which does not make sense.

Fix:

  • For all signals with this problem I changed the length accordingly based on the BOM. Now sunlink is working. Here is a 0x404 message for example. Note that this is randomizer mode and timestamps are current time in randomizer using the time.time() funciton.
    image

ishanjoshi23
ishanjoshi23 approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@ishanjoshi23 ishanjoshi23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@AarjavJain101 AarjavJain101 merged commit 78c739b into main May 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishanjoshi23 ishanjoshi23 ishanjoshi23 approved these changes

@mjohal67 mjohal67 Awaiting requested review from mjohal67

Assignees

@ishanjoshi23 ishanjoshi23

@AarjavJain101 AarjavJain101

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AarjavJain101 @ishanjoshi23