Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated DBC to contain Memorator Node and RTC Timestamp #87

Merged
merged 10 commits into from
Jun 2, 2024

Conversation

AarjavJain101
Copy link
Contributor

@AarjavJain101 AarjavJain101 commented May 24, 2024

Purpose:

  • The RTC timestamp message from the memorator needs to be accommodated by sunlink. To do this, various changes in the DBC were made. Additionally bug fixes and quality of life features were implemented.
    image

Changes:

  • The DBC now interprets message 0x751 as being from the MEMORATOR node and it interprets the 8 data bytes a double.
  • NOW the DBC message will interpret byte[0] as seconds, byte[1] as minutes, byte[2] as hours, byte[3] as day, byte[4] as month, byte[5] as year. Note that daylight savings is byte[6] but is currently not being displayed as it is not used for any calculations or anything in general. The reason for this is to directly transfer data from the memorator's timeGetDate function and copy it into the RTC type defs in firmware.
  • gps_fix signal added to TEL diagnostic message in DBC. I removed gps_sync_fail and gps_fail as they are not being used anymore (we do not sync with GPS anymore).
  • Now there is flexibility in what messages to display in the pretty printed tables in the terminal with the --table-on <OPTIONS> flag. An example is --table-on 0x751 to display the 0x751 messages only (super useful for quick debugging and checking if certain messages are correctly formatted.
  • This required changes in multiple places where I need to use the sendToParser function and as such testing will be required to ensure nothing went wrong

Action Items:

  • Test MemoratorUploader.py to ensure changes in it did not cause any issues

Detailed Monday Update
Monday Update

@AarjavJain101 AarjavJain101 changed the title Updated DBC to contains Memorator Node and RTC Timestamp Updated DBC to contain Memorator Node and RTC Timestamp May 24, 2024
Copy link
Contributor

@ishanjoshi23 ishanjoshi23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes tested and approved.

@ishanjoshi23 ishanjoshi23 merged commit b86c714 into main Jun 2, 2024
1 check passed
@ishanjoshi23 ishanjoshi23 deleted the user/Aarjavjain101/dbc_update_memorator_rtc branch June 5, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants