Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13.0 #507

Merged
merged 73 commits into from
Nov 21, 2020
Merged

0.13.0 #507

merged 73 commits into from
Nov 21, 2020

Conversation

UnHumbleBen
Copy link
Collaborator

No description provided.

dave-doty and others added 30 commits September 29, 2020 08:13
…test-on-pr-only

Modify CI UT workflow so it only run on PRs
Fixes #473; side cursor title use zy instead of xy
Remove passing in app's "currently moving" state via props and instead
directly access the global model from the view.
…move-performance

Performance improvement for strand selection
…play text, id, and idt text (depending on type of mod: 5', 3', or internal), so that it does not need to be typed in the next dialog. (useful for adding several copies of the same modification to several places in the design)
…n; now it automatically uses the IDT text field as the ID.
…t-click context menu (haven't yet implemented changing all loopout lengths at once, including setting length to 0 to convert back to crossover)
* Documentation updated
* UI logic for coordinate change
* Import logic for backward compatibility
* Helix groups import and UI logic handled as well
* Unit testing updated for new change
* Unit testing for importing older designs
  - includes older designs that uses helix groups
… two domains in the same direction, so it looks more like an insertion
…convert all to crossovers by setting length 0)
… plate if necessary (since minimum per plate is 24), and similarly for 96 strands per 384-well plate.
… a HelixGroup occupying the clicked offset, which helps with implementing twist correcting-deletions for flat square-lattice origami, for instance
…es it easier to select large groups of deletions or insertions and delete them, instead of clicking one at a time
@UnHumbleBen
Copy link
Collaborator Author

A simple idea I have would be in constants.dart, we have a Dart list of all the versions we want to provide links for, named something like scadnano_versions. In the React Menu component, we can write the logic for iterating through scadnano_versions and creating a link for each one.

If we implement it this way, we will need to remember to update both the CURRENT_VERSION and scadnano_versions variable whenever we update the version, which I feel like is a reasonable level of automation. So currently, we would probably have a scadnano_versions variable that looks like:

final scadnano_versions = [
  "0.13.0",
  "0.12.1"
];

What do you think of this idea @dave-doty ?

@dave-doty
Copy link
Member

A simple idea I have would be in constants.dart, we have a Dart list of all the versions we want to provide links for, named something like scadnano_versions. In the React Menu component, we can write the logic for iterating through scadnano_versions and creating a link for each one.

If we implement it this way, we will need to remember to update both the CURRENT_VERSION and scadnano_versions variable whenever we update the version, which I feel like is a reasonable level of automation. So currently, we would probably have a scadnano_versions variable that looks like:

final scadnano_versions = [
  "0.13.0",
  "0.12.1"
];

What do you think of this idea @dave-doty ?

Sounds good. Ideally we'll also have something that can warn us if the latest version is not the highest version on that list, to remind us to update the list.

@dave-doty
Copy link
Member

dave-doty commented Nov 19, 2020

Things to mention in release notes (add link to issue where there is an issue for it; check commits to see when issues are referenced):

  • swapped definition of x/z coordinates; should not see any change if only using web interface, but breaking change for Python scripting library: Python scripts using no grid and specifying 3D coordinates manually will have to be re-written
  • improved batch editing; can select many objects and edit/delete at once, for objects:
    • loopouts/crossovers (could delete before, now can convert between them, or change loopout lengths, in batch)
    • deletions/insertions (deleting in batch, editing insertion length in batch, and adding many deletions/insertions to many helices by pressing Ctrl when adding to one Helix)
    • modifications, edit or delete in batch
    • can select many 5' ends or many 3' ends and add the same modification to all of them at once
  • rope select mode: can draw an arbitrary non-self-intersecting polygon to select many items at once; useful for objects where a rectangular selection box would select other items that you don't want to select
  • old versions hosted at scadnano.ord/ subaddresses; might be useful in case an update breaks some functionality to have the old version available
  • anything else major??

@UnHumbleBen UnHumbleBen merged commit ba65a65 into master Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants