Fix LRT muon selection and PRW #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goblirsc
reviewed
Oct 20, 2023
added 2 commits
October 20, 2023 14:09
|
Hi @kratsg. This is a reminder for this MR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We make improvements to MuonSelector to act correctly on LRT muons. Earlier, they were just being ignored and the logic was convoluted and dirty.
After an update to PathResolver, there are problems looking for files if the path has a leading forward slash. Fixing it to get the PRW file automatically. This change was reverted in AB,24.2.26, but I still suggest removing the leading slash to not make it look like its an absolute path.
Tagging @kratsg to merge. Thanks!