Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure v5 template compatibility #67

Merged
merged 4 commits into from
Dec 10, 2021
Merged

Conversation

cadie
Copy link
Contributor

@cadie cadie commented Dec 10, 2021

Ensures that when the root directory templates are updated to utilize Athena, v5 templates are loaded if the current issue is set to 5. This will help with allowing us to push this version up to production before switching the current version to 6. This is the first PR in completing out #64.

Other Notes:

  • Updates 404.php to use different markup based on what the current version is. Basically just removed the <big> tag and adds an Athena class for the font size. The mb-4 class was also added to the heading tag, that won't change anything on the v5 side though since no styles are attributed to it.
  • Removed the get_version_front_page() function and references in the front-page.php template to it. This function was never actually getting called since we've had and will have a single page set as the homepage. get_option( 'show_on_front' ) would only not be "page" when the homepage settings are set to display posts.
  • Added TODO: Athena-ize comments to ./front-page.php and ./page.php for testing purposes. These will be removed in a future PR.
  • Adjusted by_version_template() so that the frontpage and page templates are looked for in the current version's directory before the root directory.
  • Copied the current front-page.php template to the v5 directory. The page.php v5 template is already in the v5 directory and matches the root template.
  • Removed the page.php template from the v6 directory. We will use the v6 page template from the root directory.

@cadie cadie added this to the v6.0.0 milestone Dec 10, 2021
@cadie cadie self-assigned this Dec 10, 2021
@cadie cadie merged commit c44ce7b into rc-v6.0.0 Dec 10, 2021
@cadie cadie deleted the v5-template-compatibility branch December 10, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants