Added show_excerpt and max_words shortcode attributes #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added show_excerpt and max_chars shortcode attributes to allow for the display of excerpts on card layout. - Added some css to card text - Updated readme
mikesetzer
requested review from
cjg89,
jmbarne3 and
rjucf
and removed request for
a team
|
Hey Mike! Most of us are going to be out until Monday, so I'm going to set a reminder within our Slack to look this over then. |
jmbarne3
reviewed
Nov 23, 2021
|
Two additional commits have been added that include a new layout for a material card design. Unsure if I should've closed and just resubmitted as a new pull request. Material layout was tested on mobile, tablet, and desktop. Functionally the same as the card layout with excerpts, just a different design. |
cjg89
suggested changes
Nov 30, 2021
- Replaced explode/implode, wp_strip_all_tags, and preg_replace with filters and get_the_excerpt. - Replaced "max_words" with "excerpt_length" for clarity - Updated readme to reflect shortcode changes
cjg89
reviewed
Dec 1, 2021
cjg89
approved these changes
Dec 1, 2021
jmbarne3
approved these changes
Dec 1, 2021
rjucf
approved these changes
Dec 1, 2021
cadie
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Increases the plugin display flexibility.
How Has This Been Tested?
Types of changes
Checklist: