Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/mtMemLeak removes memory leak from multithreaded routines #22

Merged
merged 7 commits into from
Mar 29, 2017

Conversation

hkashyap
Copy link
Contributor

@hkashyap hkashyap commented Mar 27, 2017

@hkashyap
Copy link
Contributor Author

We still have some leak here:

4,096 bytes in 1 blocks are definitely lost in loss record 1 of 2
==15777== at 0x4C2B8A8: operator new[](unsigned long) (vg_replace_malloc.c:423)
==15777== by 0x465F92: SNN::copyAuxiliaryData(int, int, RuntimeData_s*, bool) (in /home/hirak/CARLsim4/projects/hello_world/hello_world)
==15777== by 0x467FB4: SNN::allocateSNN_CPU(int) (in /home/hirak/CARLsim4/projects/hello_world/hello_world)
==15777== by 0x43CD48: SNN::generateRuntimeSNN() (in /home/hirak/CARLsim4/projects/hello_world/hello_world)
==15777== by 0x406431: CARLsim::setupNetwork() (in /home/hirak/CARLsim4/projects/hello_world/hello_world)
==15777== by 0x405281: main (in /home/hirak/CARLsim4/projects/hello_world/hello_world)

@tingshuc tingshuc merged commit 6486dba into master Mar 29, 2017
@hkashyap hkashyap changed the title [WIP] Fix/mtMemLeak removes memory leak from multithreaded routines Fix/mtMemLeak removes memory leak from multithreaded routines Mar 29, 2017
@mbeyeler
Copy link
Member

Sorry, I thought we're waiting on the other to-do item to be done. It's great to have memory leaks fixed and the tests pass again!

@hkashyap
Copy link
Contributor Author

We were not sure about at what point we should delete the aux data. It was a leak of some 8KB. Did not seem to be a major problem and I guess that's why Ting merged.

@tingshuc
Copy link
Member

It is intriguing. I don't think I merge fix/mtMemLeak into master. Does this happen automatically because feat/testNoCuda included fix/mtMemLeak and was merged into master?!

@hkashyap
Copy link
Contributor Author

memory leak in SNN::copyAuxiliaryData() is fixed with PR #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants