adding a lighten download csv button #937
Conversation
| for col in data[entry]: | ||
| columns.add(col) | ||
| if lighten: | ||
| columns = ["_id","best","courseid","grade","result","status","submitted_on","taskid","username"] |
There was a problem hiding this comment.
This goes against the principles of the function code, which remains content agnostic. This is one of the things we should be careful doing Python code. Things hardcoded here will clearly be missed in case of refactor (changing field names, ...).
A more robust solution should be dynamic. Something even more convenient would be to select the displayable columns in the frontend UI and send the columns ids from the form.
Another valid and more straightforward solution, as what is called here "lightened csv" is to provide the current visible columns only, is simply to make the form send back the shown columns ids.
|
I suggest to close this PR as this is better to generate the available fields on the fly based on what's inside the submission dict, and to propagate it in HTML and then in Python, instead of hardcoding the fields in the code. |
This "dummy" solution fix #936 by adding a lighten csv download button.