Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/submission_manager] catch DocumentTooLarge exception #941

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

anthonygego
Copy link
Member

Fixes #697.

This is a first mitigation and in all case useful, as the limit is set on the total command sent to the MongoDB server, which cannot be computed before.

Do not update user stats in case of error.

Runfile to test :

  #!/bin/bash
  dd if=/dev/random of=test.out bs=4M count=100
  cat test.out | tr -dc '[:alpha:]' | feedback-msg -a
  feedback-result success

Fixes #697.

This is a first mitigation and in all case useful, as the limit is set on the
total command sent to the MongoDB server, which cannot be computed before.
@anthonygego anthonygego requested a review from Drumor April 26, 2023 08:15
Copy link
Collaborator

@Drumor Drumor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Drumor Drumor merged commit f348216 into master Apr 26, 2023
@Drumor Drumor deleted the fix_697 branch April 26, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend fails to change submission status if container stdout > max DB document size
2 participants