PinholeSPECTUB

[mastergari]

Pull request for PinholeSPECTUB integrating pinhole-SPECT capabilities to STIR using code written by Carles Falcon.

[KrisThielemans]

clang-14 jobs is failing due to unrelated OpenMP error with parallelproj.

MacOS job is failing due to linking error

[  1%] Linking CXX executable test_IR_filters
                 from /Users/runner/work/STIR/STIR/src/test/numerics/test_IR_filters.cxx:21:
/usr/local/include/boost/math/tools/config.hpp:23:6: warning: #warning "The minimum language standard to use Boost.Math will be C++14 starting in July 2023 (Boost 1.82 release)" [-Wcpp]
   23 | #    warning "The minimum language standard to use Boost.Math will be C++14 starting in July 2023 (Boost 1.82 release)"
      |      ^~~~~~~
0  0x100995ffa  __assert_rtn + 139
1  0x1007c928d  mach_o::relocatable::Parser<x86_64>::parse(mach_o::relocatable::ParserOptions const&) + 4989
2  0x1007b9f8f  mach_o::relocatable::Parser<x86_64>::parse(unsigned char const*, unsigned long long, char const*, long, ld::File::Ordinal, mach_o::relocatable::ParserOptions const&) + 207
3  0x1008309d4  ld::tool::InputFiles::makeFile(Options::FileInfo const&, bool) + 2036
[  1%] Building CXX object src/buildblock/CMakeFiles/buildblock.dir/PatientPosition.cxx.o
4  0x1008[33](https://github.com/UCL/STIR/actions/runs/3548892925/jobs/5962016212#step:7:34)fa0  ___ZN2ld4tool10InputFilesC2ER7Options_block_invoke + 48
5  0x7ff817271[34](https://github.com/UCL/STIR/actions/runs/3548892925/jobs/5962016212#step:7:35)a  _dispatch_client_callout2 + 8
6  0x7ff817283c45  _dispatch_apply_invoke_and_wait + 213
7  0x7ff817283161  _dispatch_apply_with_attr_f + 1178
8  0x7ff817283327  dispatch_apply + 45
9  0x100833e2d  ld::tool::InputFiles::InputFiles(Options&) + 669
10  0x1007a4d48  main + 8[40](https://github.com/UCL/STIR/actions/runs/3548892925/jobs/5962016212#step:7:41)
A linker snapshot was created at:
	/tmp/test_IR_filters-2022-11-25-16[45](https://github.com/UCL/STIR/actions/runs/3548892925/jobs/5962016212#step:7:46)34.ld-snapshot
ld: Assertion failed: (_file->_atomsArrayCount == computedAtomCount && "more atoms allocated than expected"), function parse, file macho_relocatable_file.cpp, line 2061.

No idea why these come up now, certainly not due to changes in this PR.

[KrisThielemans]

The above errors are due to #1104 and #1103. I'm attempting to fix it in #1105.

There's one more problem that GHA uses

STIR/.github/workflows/build-test.yml

Lines 233 to 234 in 8c84f73

	cd ${GITHUB_WORKSPACE}/recon_test_pack/SPECT
	./run_SPECT_tests.sh

but run_SPECT_tests.sh has moved. This will also create trouble for our Conda recipe
https://github.com/conda-forge/stir-feedstock/blob/main/recipe/meta.yaml#L69

Maybe we can have a SPECT/run_SPECT_tests.sh that calls the 2 scripts (passing along any arguments with $*)?

[KrisThielemans]

I haven't found out why AppVeyor claims this is a non-mergeable pull request.