update master to rel 4 #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "new" projector convention. Fixes UCL#523
fixes UCL#114
require ITK 4.9
They were not run when using the `set_*` functions, but only at construction or after parsing. Fixes UCL#545
do a simple test with forward projection and reconstruction and see if the image is "close enough"
Safety improvements for reconstruction (mostly FBP)
- last test was overriding results from previous tests - compare() was doing the wrong comparison
- AnalyticReconstruction now follows same scheme for set_up as IterativeReconstruction. In particular, it no longer calls set_up() in reconstruct(image_sptr) (WARNING: this might break your code) - AnalyticReconstruction resets _already_setup=false in set_* functions - AnalyticReconstruction now also starts/stops timers (like IterativeReconstruction) - more checks if set_up has been called in AnalyticReconstruction - avoid seg-fault in get_input_data() if not initialised (both AnalyticReconstruction in IterativeReconstruction) - fixes in FBP2D and FBP3DRP for set_up() - moved checks to FBP3DRPReconstruction::set_up() (they were in reconstruct()) - changes to ReconstructionTests: filter the default image to avoid high frequency trouble, and use method_info() in diagnostics and filenames - added C++ test for FBP3DRP
After running some projections, it should be possible to call `set_up()` with an image with a different size. However, this was broken as `set_up()` only resized the `_local_output_image_sptrs vector`. Also set verbosity-level of some messages to 2. Fixes UCL#574
ForwardProjectorByBin and distributable changes to decrease default verbosity
as done in IterativeReconstruction
if set_up() has already been called, check if target-dat sizes are consistent
add a test for iterative reconstruction as well
Fix MPI projectors
More recon safety improvements
* Modified STIR's interpretation of GATE cylindrical PET geometries to be consistent with rsector/module/submodule/crystal <-> ../bucket/block/crystal * Adds View_offset and default_num_arccorrected_bins to .hroot files * updated UsersGuide.tex and sample .hroot files Co-authored-by: Kris Thielemans <k.thielemans@ucl.ac.uk>
fix ECAT7 compilation problems due to renaming
STIR built with experimental?
stir w experimental 2
the mex extension was empty since moving to CMake's FindMatlab. Fixes UCL#522
KrisThielemans
requested changes
Jun 19, 2020
KrisThielemans
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get master up to date again.