Zenodo additions #748
Zenodo additions #748
Conversation
|
For your reference, the current output of I'm surprised by some of this. In particular, some of the old PARAPET code doesn't seem correctly attributed. This could have happened in the transition from CVS to git (although I was careful). This seems to give me a too high weighting. However, overall, I guess the picture is ok. |
|
Note that this way of attributing does not count other support (including maintenance, guidance , suggestions etc), but only written software. I think this is not too unreasonable, as the papers cover that aspect. Note that I've also added DOIs to papers describing STIR components. Let me know if I missed any. Or even better just add them yourself. (@danieldeidda I might have missed HKEM paper(s)). Of |
Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org>
output formatting for zenodo.json Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org>
|
Should we edit directly, or create a PR? |
|
if you can edit, please do so |
|
As usual, I forgot [ci skip], sorry! Thanks to Daniel that made further commits....! |
|
@NikEfth, can I edit directly or only you? If not, I would create a pull request. |
|
@jafische a PR please, or just paste it here. You don't have write permissions :-( |
|
@KrisThielemans , yes that's what I thought :). Just two things: and my ORCID: 0000-0002-8329-0220 I'm a bit surprised about being at the 4th position in the list... |
I'll confess I was surprised as well... Maybe you just write very verbose code 😄 . More likely that the way that |
|
For the future I'd suggest not just counting surviving lines, but committed lines. I am sure few of the contributors that have been coding for much longer lose representation otherwise. I know that I have "tidied" code from past contributors and its a bit unfair to the that I get the credit for fixing a typo :) |
|
Presumably easy to count "committed" lines, but what if all of those are obsolete, removed? There might not be an easy automatic solution to this. On the other hand, if I look at the table above, I see 2 anomalies: myself (too much) and @ctsoumpas (not high enough). All the rest seems ok or disappears into the noise. |
|
Ah, I guess depends on how you want to give credit, but one option is to consider obsolete and removed lines generally still deserving credit, even if that is not used anymore. I dont mind really :) |
|
@KrisThielemans , so of my contribution, about 16381 lines come from the example crystal map file in examples/SAFIR-listmode-virtual-scanner/crystal_map_front.txt. Removing this (maybe the example folder altogether to help automization?) from the contribution count would somehow make sense in my opionion. |
@KrisThielemans maybe you need to Breakdown of number of lines per extension based on current master (59defaa): using
using
In particular, Not sure about |
You could open an issue/feature request at https://github.com/casperdcl/git-fame
Fixing a typo will "steal" the line. Fixing whitespace, moving lines and renaming files will not. It's hard to abuse typos enough to rank highly on the overall author list though.
yup. Could easily |
exclude files that shouldn't be counted Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org>
Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org>
exclude crystal map Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org>
|
ok, without the How do I see which lines it contributes to someone? (sorry for my ignorance) |
KrisThielemans
force-pushed
the
zenodo-rel4
branch
from
aad8c6f
to
6673eb3
Compare
shows it was Let's see what comes out with |
|
Current status: with columns I have had a look at the old There doesn't seem much that can be done about this. I presume I still have the CVS repository somewhere, but I don't fancy converting that again to git, and then grafting the later history on top of that (creating new hashes, and therefore essentially ruining everybody's STIR clone). Although of course, @casperdcl could know a solution for that! Affected people are: |
you could do something like |
I opened casperdcl/git-fame#50 and then implemented it :) I'll be some time before I get around to writing tests & releasing but for now you can try: pip install "https://github.com/casperdcl/git-fame/archive/devel.zip"
git-fame --loc=ins,del # insertions plus deletions
git-fame --loc=insertions # just insertions
git-fame --loc=surviving # only surviving lines (default)I'd be very interested if this changes the author order meaningfully @KrisThielemans @AnderBiguri
git fame -wMC --loc=insertions --log=ERROR --format=json --excl \
'\.(eps|root|ahv|hv|v|hs|s|scan|l|hdr|rtf|gz|if|pdf|safir|options|png|cls|sty)$|external_helpers|crystal_map_front.txt|Doxyfile'takes ~30sec (or ~2sec without {"total": {"loc": 547665, "files": 4896, "ctimes": 16027, "commits": 6670}, "data": [
["Kris Thielemans", 404609, 4972, 3147, 73.9, 74.5, 64.3],
["Sanida Mustafovic", 24910, 343, 173, 4.5, 5.1, 3.5],
["Nikos Efthimiou", 21742, 219, 262, 4.0, 3.3, 5.4],
["Charalampos Tsoumpas", 18182, 371, 172, 3.3, 5.6, 3.5],
["Jannis Fischer", 17686, 12, 31, 3.2, 0.2, 0.6],
["Richard Brown", 9953, 109, 397, 1.8, 1.6, 8.1],
["Matthew Jacobson", 7584, 73, 42, 1.4, 1.1, 0.9],
["Claire Labbe", 7044, 43, 15, 1.3, 0.6, 0.3],
["Palak Wadhwa", 4914, 64, 54, 0.9, 1.0, 1.1],
["Tim Borgeaud", 4319, 23, 42, 0.8, 0.3, 0.9],
["Tobias Beisel", 3621, 2, 15, 0.7, 0.0, 0.3],
["Daniel Deidda", 3414, 78, 95, 0.6, 1.2, 1.9],
["Alexey Zverovich", 2963, 6, 35, 0.5, 0.1, 0.7],
["Nikos Dikaios", 2646, 50, 44, 0.5, 0.7, 0.9],
["Pablo Aguiar", 1980, 28, 26, 0.4, 0.4, 0.5],
["Ashley Gillman", 1663, 26, 29, 0.3, 0.4, 0.6],
["C. Ross Schmidtlein", 1622, 2, 6, 0.3, 0.0, 0.1],
["Edoardo Pasca", 1611, 1, 15, 0.3, 0.0, 0.3],
["Ander Biguri", 1404, 59, 31, 0.3, 0.9, 0.6],
["Ottavia Bertolli", 922, 15, 22, 0.2, 0.2, 0.4],
["Robert Twyman", 799, 14, 29, 0.1, 0.2, 0.6],
["Ludovica Brusaferri", 786, 29, 32, 0.1, 0.4, 0.7],
["Nacer Kerrouche", 679, 11, 12, 0.1, 0.2, 0.2],
["Patrick Valente", 624, 2, 5, 0.1, 0.0, 0.1],
["Benjamin Thomas", 462, 22, 20, 0.1, 0.3, 0.4],
["Evgueni Ovtchinnikov", 377, 26, 27, 0.1, 0.4, 0.6],
["Matthias Ehrhardt", 252, 6, 42, 0.0, 0.1, 0.9],
["Darren Hague", 228, 13, 4, 0.0, 0.2, 0.1],
["Katie Dinelle", 227, 9, 9, 0.0, 0.1, 0.2],
["David Völgyes", 211, 17, 36, 0.0, 0.3, 0.7],
["Mustapha Sadki", 93, 3, 1, 0.0, 0.0, 0.0],
["Elise Emond", 70, 6, 13, 0.0, 0.1, 0.3],
["Damiano Belluzzo", 23, 3, 2, 0.0, 0.0, 0.0],
["Alaleh Rashidnasab", 20, 1, 2, 0.0, 0.0, 0.0],
["Alexander C. Whitehead", 9, 5, 2, 0.0, 0.1, 0.0],
["Casper da Costa-Luis", 6, 1, 1, 0.0, 0.0, 0.0],
["Parisa Khateri", 4, 2, 2, 0.0, 0.0, 0.0],
["Rebecca Gillen", 2, 1, 1, 0.0, 0.0, 0.0],
["Yu-jung Tsai", 2, 1, 1, 0.0, 0.0, 0.0],
["tokkot", 1, 1, 1, 0.0, 0.0, 0.0],
["Holger Kohr", 1, 1, 1, 0.0, 0.0, 0.0]],
"columns": ["Author", "loc", "coms", "fils", "%loc", "%coms", "%fils"]} |
|
@casperdcl I tried adding |
|
er. afaik |
|
alright. Since 2003-06-27 (rel 1.1) we get That still gives me too much, but it doesn't matter for order of course. Now I need to decide on how to put the PARAPET people in here. My feeling is that the most reasonable thing to do is to put them above the "very small" contributions, which I'll (arbitrarily) give a cut-off of ~30 I'll commit this now. |
This PR adds a
.zenodo.jsonfile to STIR. This is in preparation for our next release which will be uploaded to Zenodo. It will give us a DOI for the release, and a DOI for the latest release.For a very long standing project as STIR, attribution is quite hard. I've currently chosen the following route:
Feel free to discuss other fair (and ideally automatic) options.
I've not included affiliations in the
.zenodo.json, as these have changed for many of us multiple times (unless it's possible to add multiple affiliations, and people volunteer to put those in).I have included a few ORCIDs for those where I happened to have them. Feel free to contribute yours (please use
[ci skip]in the first line of your commit)