Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring ~iterator.cpp~ SimulationManager::execute() #63

Open
3 of 7 tasks
t-young31 opened this issue Aug 9, 2022 · 1 comment
Open
3 of 7 tasks

Refactoring ~iterator.cpp~ SimulationManager::execute() #63

t-young31 opened this issue Aug 9, 2022 · 1 comment
Labels
enhancement New feature or request testing Adding or requesting more test coverage

Comments

@t-young31
Copy link
Member

t-young31 commented Aug 9, 2022

mexFunction in iterator.cpp is the best part of 7k lines. This should be broken out into smaller functions with structs/classes for the commonly grouped function arguments.


@t-young31 t-young31 added the enhancement New feature or request label Aug 9, 2022
@t-young31 t-young31 self-assigned this Aug 9, 2022
@t-young31 t-young31 linked a pull request Aug 9, 2022 that will close this issue
@t-young31 t-young31 added the testing Adding or requesting more test coverage label Aug 9, 2022
@t-young31 t-young31 removed a link to a pull request Aug 9, 2022
This was referenced Aug 9, 2022
This was referenced Sep 5, 2022
@t-young31 t-young31 removed their assignment Oct 10, 2022
This was referenced Dec 19, 2022
This was referenced Jan 4, 2023
@willGraham01
Copy link
Collaborator

willGraham01 commented Apr 4, 2023

Just putting an update here with regards to the current state of the codebase; for anyone coming to the project fresh and not knowing where iterator actually is anymore.

iterator.cpp has largely been absorbed into the SimulationManager's execute() method, however further refactoring is possible/ongoing. The majority of what remains in execute() is the main body of code lifted directly from iterator.cpp that constituted the main loop (iteration step) of the simulation.

Setup of the data structures, scoping of loop variables, preparation of the output and post-loop processing methods have already been implemented.

@willGraham01 willGraham01 changed the title Refactoring iterator.cpp Refactoring ~iterator.cpp~ SimulationManager::execute() Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing Adding or requesting more test coverage
Projects
None yet
Development

No branches or pull requests

3 participants