co: only appts that require HSI to maintain on need to have a known date of last appt #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to have known date of appt in the past
tbhallett
reviewed
Oct 13, 2022
tbhallett
approved these changes
Oct 13, 2022
tamuri
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The date of last appt for contraception methods based on
days_between_appts_for_maintenancefor the methods which do not require HSI to maintain doesn't make sense.I need to change the type of parameter
days_between_appts_for_maintenancefrom an integer to a list and assign to each contraception method its owndays_between_appts_for_maintenance, I can't do that for the methods that do not require appt for maintenance because for them this number of days cannot be set.