-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/adding fraction symbols #438
Conversation
Have remapped the new custom ones: |
There's a file It looks like there's a separate symbols.json for each of local, development, and production though I'm not sure why (they're all the same size so I assume they're identical). They'll all need updating. Also, there's a weird bug where custom symbols I've added to the symbol picker are really hard to click on. Is that just a firefox thing or do you have that problem too? |
I remember there was a bit of strange behaviour with the bottom row of symbols not being selectable when they didn't have width but since fixing that I haven't had any issues |
keeping copies of the old ones for dev and prod in case something goes wrong - can be deleted later
Also, at some point the alphabetum file name changed from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When starting with a blank database I get an error saying the symbolgroup with pk=17 doesn't exist. I think this is because you haven't included the new symbol groups in symbols.json?
Traceback (most recent call last):
django | File "/usr/local/lib/python3.8/site-packages/django/db/backends/utils.py", line 82, in _execute
django | return self.cursor.execute(sql)
django | psycopg2.errors.ForeignKeyViolation: insert or update on table "research_symbol" violates foreign key constraint "research_symbol_group_id_50891aa4_fk_research_symbolgroup_id"
django | DETAIL: Key (group_id)=(17) is not present in table "research_symbolgroup".
This all looks good to me now. Just to say, if you're keeping a pre-2024 copy around in case you want to go back later, it's under version control so you can just checkout the old version of that file from a previous commit. |
closes #24
Also closes #448 and #387 since the process is now known
alphabetum.css
file and this is imported into the base template