-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/duplicate fragments #439
Conversation
A couple of things still to do:
|
would it work in that when duplicating, if the original has duplicates, add those items to the new instance's list of duplicates and it to theirs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get an error when converting an anonymous fragment with duplicates into an unlinked fragment. To reproduce:
- Duplicate an anonymous fragment
- Convert the original anonymous fragment to unlinked
Result:
ValueError: Cannot query "Unlinked 450": Must be "AnonymousFragment" instance.
), | ||
), | ||
migrations.AddField( | ||
model_name="testimonium", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we raise the issue of what to do about testimonia? I can see there's no option to duplicate testimonia on the detail page, but wasn't sure if we'd asked about this?
If it's not an option, these fields are redundant, but I guess not causing any harm. Maybe just add a comment here and in models/base.py to state that these are here and why if that's the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we did ask if we should enable it for them, I'll make note to do that. They are currently redundant but are there because it's on the HistoricalBaseModel
and it complained when I removed this from the migration.
conversion issue should be fixed now but initially the new fragment page didn't load and I had to reload for it to display, wondering if this was specific to my device |
I think the migration leaf node error we're seeing is because GH actions actually runs some kind of merged version of this branch and development together. Usually it's quite good at telling you there's a conflict, but in the case of migrations it's not clever enough to warn that development has a 0070 migration file and so does this branch. TL;DR: Merge development into this branch and resolve the migration conflict by making this branch's migration file 0071. |
closes #393