Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating production #458

Merged
merged 180 commits into from
Jun 6, 2024
Merged

Updating production #458

merged 180 commits into from
Jun 6, 2024

Conversation

acholyn
Copy link
Collaborator

@acholyn acholyn commented Jun 6, 2024 •
edited
Loading

Adding:

  • fragment duplication
  • public commentary
  • shortening @ mentions for bib items
  • adding apposita to anonfrags
  • font symbols
  • switching editor to CKEditor

acholyn and others added 30 commits February 15, 2024 10:19
@acholyn
basis for duplicating fragments
9e2959e
@acholyn
fleshing out the other parts of duplcation - esp with OT
096a7c2
@acholyn
tweaks for behaviour + tests
6f0cc9c
@acholyn
refactoring + tests
9a42292
@acholyn
expanding to include anonymous frags
96e62ca
@acholyn
adding new PublicCommentaryMentions model
9513c4f
@acholyn
mig + initial templating for public commentary
5531d67
@acholyn
tweaks for anonfrags
a21fe90
@acholyn
updating urls, forms and views
b33f0ba
@acholyn
changing migration so it's an actual model
e7cbeac
@acholyn
allowing updating of pcm on detail page
f337bf3
@acholyn
adding urls and views for cancel (view it normally)
6d32c8d
@acholyn
updating templates
8928c45
@acholyn
adding toggle for public mentions section
5e5830f
@acholyn
adding help text for approved field
1edcce5
@acholyn
fixing typos for tetsimonium permission
72d065a
@acholyn
form test
af0d50f
@acholyn
sketching out
779f769
@acholyn
fleshing out
fd49de7
@acholyn
tweaks because broken links break mentions
9eea125
@acholyn
no mentions = nothing to transfer
d8232c3
@acholyn
fixing imports
ee68e4a
@acholyn
using model name instead of request.path
2b04232
@acholyn @tcouch
Apply suggestions from code review re urls
a5251ed 
Co-authored-by: Tom Couch <t.couch@ucl.ac.uk>
@acholyn
streamlining + tidying
c6c348a
@acholyn
remove instance from mentions if it doesn't exist anymore
834b603
@acholyn
adding call to update the displayed text after mentions reassigned
18755c3
@acholyn
prints for debugging
3a6d0b6
@acholyn
fixing successurl test
5eb66b4
@acholyn
another place
1f6f9b5
acholyn and others added 28 commits May 22, 2024 10:53
@acholyn
attempted and failed abstraction - todo
21f0027
@acholyn
adding classes to forms
82b8548
@acholyn
updating forms to use classes + removing RTE refs
7c753c7
@acholyn
fixing mentions
8ec952c
@acholyn
ap crit tweaks
0280a48
@acholyn
mentions?
f42258c
@acholyn
fixing mentions? (works now)
84814d3
@acholyn
removing quill bits
cbcdf02
@acholyn
tweaks + tody
046971b
@acholyn
cke tweaks + styling
6c96f68
@acholyn
removing ql
11038b4
@acholyn
fixing subsequent ap crit new lines not rendering properly - couldn't…
f8d9c02 
… find builder area
@acholyn
fixing ap crit delete behaviour
f87ad3d
@acholyn
updating duplication to fix apcrit refs in ot + test
68da4cb
@acholyn
updating ot references in real time with apcrit
caf4ef0
@acholyn
tidying
72a17fe
@acholyn
throttling to 300ms
72150ad
@acholyn
fixing errors
0bec916
@tcouch
Fix inline app crit editor buttons
91af9b1
@acholyn
updating apcrit regex
0b951a5
@tcouch
Fix for publiccommentary editor
28cd8be
@acholyn
adding footnotes to intro forms
83c0e08
@acholyn
Merge branch 'fix/mentions-preventing-tofs' of github.com:UCL/frrant …
014374d 
…into fix/mentions-preventing-tofs
@acholyn
enabling ckeditor in more forms + taking first ot pk for commentary attr
439838c
@acholyn
some styling for footnotes on detail page
cc832a9
@acholyn
small fix for form test
59a3b0b
@acholyn
fixing create forms
390a4d8
@acholyn
Merge pull request #453 from UCL/fix/mentions-preventing-tofs
3d08d5f 
Switch to CKEditor
@acholyn acholyn changed the title Updating text editor on production Updating production Jun 6, 2024
@acholyn acholyn merged commit 063e27c into production Jun 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acholyn @tcouch