Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert basic google analytics #149

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Insert basic google analytics #149

merged 2 commits into from
Nov 28, 2018

Conversation

sourcefilter
Copy link
Contributor

This duplicates #143, except that it inserts into blacklight.html.erb [correct!] instead of application.html.erb [incorrect!], and that it pulls the Google Tag Manager ID from an environment variable

Connected to #137

@coveralls
Copy link

coveralls commented Nov 27, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 376

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.182%
Totals Coverage Status
Change from base Build 352: 0.0%
Covered Lines: 108
Relevant Lines: 110
💛 - Coveralls

@jendiamond jendiamond merged commit 185a32f into master Nov 28, 2018
@jendiamond jendiamond removed the review label Nov 28, 2018
@jendiamond jendiamond deleted the analytics branch November 28, 2018 17:54
pghorpade pushed a commit that referenced this pull request Nov 18, 2019
@jendiamond
Merge pull request #149 from UCLALibrary/analytics
a7771a9 
Insert basic google analytics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sourcefilter @coveralls @jendiamond