Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: citation bugs #263

Merged
merged 1 commit into from
Mar 11, 2019
Merged

fix: citation bugs #263

merged 1 commit into from
Mar 11, 2019

Conversation

sourcefilter
Copy link
Contributor

@sourcefilter sourcefilter commented Mar 8, 2019 •
edited
Loading

  • use placeholder text when a field is missing
  • build URL off ENV['RAILS_HOST'] instead of always 'ursus-test'
  • use dlcs_collection_name_ssm instead of publisher_tesim

connected to #249
connected to #260

@sourcefilter
fix: citation bugs
d949495 
- placeholder text when a field is missing
- build URL off ENV['RAILS_HOST'], not 'ursus-test'
- use dlcs_collection_name_ssm instead of publisher_tesim
@coveralls
Copy link

Pull Request Test Coverage Report for Build 605

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.9%) to 93.421%
Totals Coverage Status
Change from base Build 601: 3.9%
Covered Lines: 142
Relevant Lines: 152
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 617

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.9%) to 93.421%
Totals Coverage Status
Change from base Build 601: 3.9%
Covered Lines: 142
Relevant Lines: 152
💛 - Coveralls

@bess bess merged commit 0618450 into master Mar 11, 2019
@bess bess deleted the 249-citation-bug branch March 11, 2019 14:32
@bess bess removed the review label Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bess bess bess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sourcefilter @coveralls @bess