Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_select_buildings() fails when self.target_units is pd.DataFrame #70

Open
alephcero opened this issue Dec 9, 2019 · 0 comments
Open

_select_buildings() fails when self.target_units is pd.DataFrame #70

alephcero opened this issue Dec 9, 2019 · 0 comments
Labels
Type: Bug

Comments

@alephcero
Copy link
Contributor

Function _select_buildings() fails when self.target_units is a pd.DataFrame. While in the first lines checks for the target_units type, then it gets used in followings functions disregarding it.
alephcero added a commit that referenced this issue Dec 9, 2019
@alephcero
Change target_units depending on type. Issue #70
62cd3e0
alephcero added a commit that referenced this issue Jan 9, 2020
@alephcero
Merge pull request #71 from UDST/bug/issue_70
46de3fe 
As target_units can be either a `int` or `DataFrame`, the number of units to build could be the same `int` or come from the sum of a column in the df.  

Related to #70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alephcero