Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major changes to Developer class interface #25

Merged
merged 17 commits into from
Feb 15, 2017
Merged

Major changes to Developer class interface #25

merged 17 commits into from
Feb 15, 2017

Conversation

pksohn
Copy link
Contributor

@pksohn pksohn commented Feb 11, 2017

This PR makes some major updates to the Developer class - not to the core functionality, but to the way it works with parameters, and most changes are basically to make the format consistent with the SqftProForma object. Addresses #11 and #22.

I took a crack at this but I'm not sure this is the best solution. See what you think. I could be convinced that we should leave some of the parameters out of the Developer object, like agents and buildings. It's hard to know what's the right separation between the parcel model functions and the core Developer object.

  • Constructor: I brought a lot more parameters into this object than previously. This is largely due to bringing some functionality from the parcel model's utils.py into this module. See for example this function which has been brought inside the Developer object, along with the agents and buildings tables and other parameters.
  • Add from_yaml, to_dict, and to_yaml functionalities.
  • Major revamp of unit tests given new required parameters for instantiating the Developer object.

@conorhenley conorhenley merged commit bc1f03a into master Feb 15, 2017
@conorhenley conorhenley deleted the developer branch February 15, 2017 19:24
This was referenced Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants