-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3 compatibility #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several code changes to be compatible with Python 3, and changes the Travis build to work with Python 3.5 and 3.6. Addresses #29. This is necessarily in parallel with changes to
urbansim_parcels
,pandana
,osmnet
, andurbansim
; running a simulation using Python 3 using this new codebase also requires Python 3 compatibility with several of the above. The Travis build currently grabs the py3-compatible branches of the above, so that will have to be updated over time.Code compatibility changes
from __future__ import print_function
developer.py
module renamed todevelop.py
to avoid namespace conflict related to absolute imports.dict
:iteritems()
method replaced withitems()
(same behavior),dict.keys().sort()
changed tolist(dict.keys()).sort()
.from __future__ import division
in python 2. I manually checked all of the division operations against test data and they return the same arrays either way.Travis build changes
python3-support
branch (along with similar installation ofosmnet
).python3
branchpksohn/python3
fork/branchAgain, we'll just have to keep track of where the Travis builds are pulling code from. It should get much simpler as we merge changes into master branches.