Allow to_frame() to take a string outside of a sequence #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorhenley
approved these changes
May 23, 2017
There was a problem hiding this comment.
This looks good to me. I'm fairly certain that, even though it's not indicated in the docstrings, the single column passed as a string had worked in .to_frame() since very early on (and was perhaps even in the simulation framework). I don't see a reason not to support it if it's this simple.
|
yeah I'm for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27.
@fscottfoti would like to see if you have any thoughts. @Eh2406 you might also be interested since this involves your code in the to_frame() method. Please see #27 for a better description.