Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix groupby unit test #35

Merged
merged 2 commits into from
Aug 1, 2017
Merged

Fix groupby unit test #35

merged 2 commits into from
Aug 1, 2017

Conversation

pksohn
Copy link
Contributor

@pksohn pksohn commented Aug 1, 2017

In response to #34. The pandas v0.20.1 release in May caused a test involving groupby to fail, and I made a quick fix in #28. It turns out that fix made tests pass in versions of Pandas >= 0.20.1, but fail in versions < 0.20.1.

This PR makes the failing test work with versions of Pandas before and after 0.20.1.

@pksohn pksohn requested a review from janowicz August 1, 2017 19:00
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.599% when pulling 10ce43d on groupby_test into 9b852b8 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.599% when pulling 10ce43d on groupby_test into 9b852b8 on master.

@pksohn pksohn merged commit 07b34ae into master Aug 1, 2017
@pksohn pksohn deleted the groupby_test branch August 1, 2017 23:25
@pksohn pksohn mentioned this pull request Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants