-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.1.dev21] Beter data loading utilities #74
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxndrwgrdnr
approved these changes
Dec 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, Sam. Thanks for getting this done so quickly.
Pull Request Test Coverage Report for Build 79
💛 - Coveralls |
Pull Request Test Coverage Report for Build 81
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 81
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the utility that templates use to load estimation or simulation data from Orca.
Functionality
It removes
TemplateStep._get_df()
and replaces it with a new functionutils.get_data()
. See snapshot here: utils.py#L127-L202Automatically detects columns included in the model expression and filters. Ignores any columns not found in the source tables, to support use cases where data is assembled separately for choosers and alternatives and then merged together -- the model expression in that case would include terms from both sets of tables.
Discussion
This should fix the problem that @mxndrwgrdnr raised in this comment on issue #67, where incidental overlapping columns in the choosers and alternatives table were preventing a MergedChoiceTable from being built properly. After this update, incidental columns would be dropped.
This should also improve performance -- reducing memory usage and possibly improving speed a bit.
Other changes
templates that used
TemplateStep._get_df()
have been updated to useutils.get_data()
insteadtemplates using the older
TemplateStep._get_data()
method are unchanged; that migration will be easier as part of the switch to settings objects (see issue Settings objects for groups of common parameters #54)implemented the
run_all()
method for the Segmented MNL templateupdates to unit tests
Versioning