-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOTH changes #70
Merged
Merged
MOTH changes #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for making the updates. I organized my review by the github issue
number.
#61
I think the NWI data shown on this version of the app comes from NWI
directly. It seems to me like it loads slower than the old way we were
serving up the data and it took me a while to figure out why the data
weren't displaying until I zoomed in far enough. We talked about going back
to using the old method of getting the NWI data into the app, but spruced
up with some simple code. Can we revert back to the old version of the NWI
data for now (since it loads faster) and then come back to this issue when
I have a chance to create some code to get the NWI data processed and ready
for the app?
#62
I will leave this to Pete for a more in-depth review but I noticed two
things.
There is a typo in the pop-up for the LLWW Popup for LLWW descriptions- the
word "Attributes" is misspelled
Also, I think when you download the data, the data explanation file should
probably be a pdf doc.
#64- looks good
#66- looks good
#69- looks good
Thanks!
…On Thu, Jan 26, 2023 at 10:46 AM Jay Hill ***@***.***> wrote:
Issues 62, 64, 66, 69 and partially 61 addressed
@marshallrobinson <https://github.com/marshallrobinson> @wetlandsDiane
<https://github.com/wetlandsDiane> @PeteGoodwinUGS
<https://github.com/PeteGoodwinUGS> please review here
https://geology.utah.gov/apps/wetlands/review/index.html
------------------------------
You can view, comment on, or merge this pull request online at:
#70
Commit Summary
- 45f47b3
<45f47b3>
remove boundary layer
- 5426a8f
<5426a8f>
removed boundaries from about panel
- 8ce60cb
<8ce60cb>
Change names of wetland & rip metadata issue#64
- 2bd96ea
<2bd96ea>
link to database panel in info panel issue #66
- 353a8ab
<353a8ab>
layer info added
- 44d6e52
<44d6e52>
llww layers added
- 8bc4a14
<8bc4a14>
llww symbology working
- 24f97a8
<24f97a8>
LLWW Descriptions popup working
- f5ff6e7
<f5ff6e7>
llww mapping areas popup working
File Changes
(2 files <https://github.com/UGS-GIO/wetlands/pull/70/files>)
- *M* index.html
<https://github.com/UGS-GIO/wetlands/pull/70/files#diff-0eb547304658805aad788d320f10bf1f292797b5e6d745a3bf617584da017051>
(7)
- *M* map.js
<https://github.com/UGS-GIO/wetlands/pull/70/files#diff-3d5c8fd7f25f45ade45f26c8ba4beece327956f5fdaeb95e0a814ee6eab38cc5>
(313)
Patch Links:
- https://github.com/UGS-GIO/wetlands/pull/70.patch
- https://github.com/UGS-GIO/wetlands/pull/70.diff
—
Reply to this email directly, view it on GitHub
<#70>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE3KRTS2O6LDPCKFYUVQRW3WUKZ5PANCNFSM6AAAAAAUHY6YHM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
[image: Photo]
[image: Facebook icon] <https://facebook.com/UTGeologicalSurvey>[image:
Twitter icon] <https://twitter.com/utahgeological>[image: Instagram icon]
<https://www.instagram.com/utahgeologicalsurvey/>[image: LinkedIn Icon]
<https://www.linkedin.com/company/utah-geological-survey>
Diane Menuz
State Wetlands Coordinator
O: (801) 538-7436
E: ***@***.***
Utah Department of Natural Resources
Utah Geological Survey
geology.utah.gov
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues 62, 64, 66, 69 and partially 61 addressed
@marshallrobinson @wetlandsDiane @PeteGoodwinUGS please review here https://geology.utah.gov/apps/wetlands/review/index.html