Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1260 - iOS tapbar covering content at the bottom #1273

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

mxilievski
Copy link
Contributor

@mxilievski mxilievski commented Apr 11, 2023

This is the "safest" fix since I don't have much context of the code. Feel free to suggest a more appropriate fix.

Additional information

Bottom content is now fully visible:
image

As well as content on the top:
image

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have followed the contribution guidelines
    • This PR is for a custom-card or documentation change and therefore directed to the main branch.
    • This PR is for a official card or any other directly to the integration related change and therefore directed to the release branch.

This is the "safest" fix since I don't have much context of the code. Feel free to suggest a more appropriate fix.
@mxilievski mxilievski changed the title Fixes #1260 Fixes #1260 - iOS tapbar covering content at the bottom Apr 11, 2023
@basbruss basbruss changed the base branch from main to release April 13, 2023 07:31
Copy link
Collaborator

@basbruss basbruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The last missing piece after those hard frontend changes 😄

@basbruss basbruss merged commit b4f86b8 into UI-Lovelace-Minimalist:release Apr 13, 2023
@mxilievski mxilievski deleted the patch-1 branch April 13, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS tapbar covering content at the bottom
2 participants